Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Portscope carrier #8

Merged
merged 3 commits into from
Apr 29, 2013
Merged

Portscope carrier #8

merged 3 commits into from
Apr 29, 2013

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Apr 26, 2013

Allow to set carrier in portscope
FIX: Issue #3

@paulfitz
Copy link
Member

Maybe squash some/all of the commits, we don't necessarily need all that blow-by-blow history? Although we've never been fussy about this before...

@drdanz
Copy link
Member Author

drdanz commented Apr 29, 2013

I think that some granularity in commits makes patches a lot easier to understand (and to review) and simplifies a lot when using git bisect to find regression bugs, that's why I usually make small commits...
Also by using feature branches, when you see the history, even if it branches have a larger number of commits, you can clearly see that these commits are related.
Anyway you are probably right that 6 commits were too many I squashed some of them, does it look better now?

paulfitz added a commit that referenced this pull request Apr 29, 2013
@paulfitz paulfitz merged commit f84d69a into robotology:master Apr 29, 2013
@drdanz drdanz deleted the portscope_carrier branch April 29, 2013 15:11
@randaz81 randaz81 mentioned this pull request Oct 26, 2015
drdanz added a commit to drdanz/yarp that referenced this pull request Dec 15, 2016
drdanz added a commit to drdanz/yarp that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants