Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that files generated by yarp_configure_plugins_installation are relocatable #3069

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

traversaro
Copy link
Member

Fix #2445, using the strategy described in that issue.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

51.4% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@traversaro
Copy link
Member Author

As discussed with @randaz81, I will report the output of tests on Windows before merging.

@traversaro
Copy link
Member Author

traversaro commented Jan 12, 2024

As discussed with @randaz81, I will report the output of tests on Windows before merging.

I just tested on Windows, and the plugins can be found well, so the PR should be good to go.

@randaz81 randaz81 self-requested a review January 12, 2024 18:13
@randaz81 randaz81 merged commit c59779f into robotology:master Jan 17, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not generate non-relocatable files in yarp_configure_plugins_installation
2 participants