yarpviz: Support compilation with graphviz >= 9 #3056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
had a problem deploying
to
code-analysis
GitHub Actions
Failure
traversaro
temporarily deployed
to
code-analysis
GitHub Actions
Inactive
randaz81
reviewed
Nov 28, 2023
| @@ -93,7 +93,9 @@ class QGVCore | |||
| rdr.len = strlen(cp); | |||
| rdr.cur = 0; | |||
|
|
|||
| #ifndef GRAPHVIZ_VERSION_GE_9 | |||
| disc.mem = &AgMemDisc; | |||
There was a problem hiding this comment.
Unclear: which are the implications of removing disc.mem? Is it safe?
There was a problem hiding this comment.
In graphviz, there is not anymore any support for custom memory allocators, see https://gitlab.com/graphviz/graphviz/-/blob/main/CHANGELOG.md#900-2023-09-11 :
Breaking: The concept of “memory allocator discipline” has been removed,
along with the type Agmemdisc_t and fields Agdisc_t.mem and
Agdstate_t.mem.
The default memory allocators are used by default in graphviz 9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix robotology/robotology-superbuild#1537 .