-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yarpmotorgui with displayed hardware faults messages #2764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randaz81
added
PR Type: Feat/Enh
This PR adds some new feature or enhances some part of YARP
Component: Library - YARP_dev
Component: Devices
Component: GUI - yarpmotorgui
Target: YARP v3.6.0
labels
Nov 18, 2021
randaz81
requested review from
drdanz,
Nicogene and
traversaro
as code owners
November 18, 2021 17:03
PeterBowman
reviewed
Nov 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I wonder if
bool getLastJointFault(int j, int* fault, std::string& message)
would be more consistent with existing interfaces (note the second parameter, as a primitive type, is passed as a pointer instead of by-reference). - Could you please also register this new interface in yarp.i? I think it just needs an
%include
, aCAST_POLYDRIVER_TO_INTERFACE(IJointFault)
and an extension for output parameters such as this (not tested):(change%extend yarp::dev::IJointFault { bool getLastJointFault(int j, std::vector<int>& fault, std::vector<std::string>& message) { return self->getLastJointFault(j, fault[0], message[0]); } }
fault[0]
to&fault[0]
if a pointer is passed instead of a reference)
randaz81
force-pushed
the
yarpmotorgui_hwfault
branch
from
November 24, 2021 11:23
2584562
to
1e2a4c4
Compare
Thank you @PeterBowman |
drdanz
approved these changes
Dec 2, 2021
/rebase |
…displays the internal hardware error * Added new interface IJointFault with method: IJointFault * IJointFault is now implemented by RemoteControlBoard and ControlBoard_nws_yarp * fakeMotionControl.cpp now simulates an hardware fault when it receives a TorqueCommand > 1Nm
drdanz
force-pushed
the
yarpmotorgui_hwfault
branch
from
December 2, 2021 11:02
0caf315
to
ed8c652
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Devices
Component: GUI - yarpmotorgui
Component: Library - YARP_dev
PR Type: Feat/Enh
This PR adds some new feature or enhances some part of YARP
Resolution: Merged
Target: YARP v3.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion: robotology/community#561