Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of Python Bindings on Windows #2527

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

traversaro
Copy link
Member

Without this fix, the compilation of Python bindings is failing with error:

2021-03-22T08:34:49.9037393Z   -- Found Python3: C:/Miniconda/envs/test/python.exe (found version "3.9.2") found components: Interpreter Development Development.Module Development.Embed 
2021-03-22T08:34:49.9045986Z   CMake Error at bindings/python/CMakeLists.txt:17 (get_filename_component):
2021-03-22T08:34:49.9047185Z     get_filename_component called with incorrect number of arguments
2021-03-22T08:34:49.9047925Z   
2021-03-22T08:34:49.9079080Z   -- Configuring incomplete, errors occurred!

The reason is that for the modern FindPython3 CMake module Python3_LIBRARY is not an output, so the code does not work. However, the whole logic seems not to be necessary anymore with modern CMake and modern Python (tested with Python 3.9), so I think we can just remove it altogether.

@traversaro traversaro requested a review from drdanz as a code owner March 23, 2021 09:43
@traversaro traversaro temporarily deployed to code-analysis March 23, 2021 10:16 Inactive
@traversaro traversaro temporarily deployed to code-analysis March 23, 2021 10:16 Inactive
@traversaro traversaro temporarily deployed to code-analysis March 23, 2021 10:16 Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@drdanz

This comment has been minimized.

@drdanz drdanz added the Component: Bindings swig, python, java, ruby, perl, octave, matlab, lua, csharp, tcl label Mar 26, 2021
@drdanz drdanz force-pushed the fix-python-bindings branch from 8c6c4db to 61ecb92 Compare March 26, 2021 16:04
@drdanz drdanz merged commit 25e95b2 into robotology:yarp-3.4 Mar 26, 2021
@drdanz
Copy link
Member

drdanz commented Mar 26, 2021

Merged, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Bindings swig, python, java, ruby, perl, octave, matlab, lua, csharp, tcl PR Type: Bugfix This PR fixes some bug Resolution: Merged Target: YARP v3.4.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants