-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operator conflict #2421
Fix operator conflict #2421
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would update the release notes by adding a file in |
Does the removal of said operator affect in any way the yarp/src/libYARP_os/src/yarp/os/LogStream.h Lines 224 to 230 in 13d2bc8
|
Hi @Giulero checking the CI seems that function you removed is widely used in yarp |
@PeterBowman thank you for pointing this out! @GiulioRomualdi, indeed. The removal seems quite harmful. |
I think that pasting the body of the deleted function into |
@PeterBowman suggestion is probably the best option |
Also I believe that instead of moving the implementation in Types.h might not be needed after moving the implementation... |
Sorry for the late response. I totally agree with @drdanz and @PeterBowman , the problem that caused #2067 is adding new operators in the std namespace, adding new operators for the classes in YARP is totally fine. |
This was causing a conflict with Casadi Fixes robotology#2067 Replaces robotology#2421
Closing this in favour of #2548 |
This was causing a conflict with Casadi Fixes robotology#2067 Replaces robotology#2421
This pull request should fix #2067.
cc @GiulioRomualdi @traversaro