-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various fixes rgbd sensors/wrapper #1878
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
added
Component: Documentation
Component: Library - YARP_dev
Component: Devices
Type: Cleanup
Involves cleaning up some part of YARP
PR Type: Bugfix
This PR fixes some bug
Target: YARP v3.1.1
labels
Sep 26, 2018
Nicogene
requested review from
drdanz,
traversaro,
barbalberto and
claudiofantacci
September 26, 2018 09:35
traversaro
reviewed
Sep 26, 2018
@@ -248,14 +249,14 @@ class YARP_dev_API yarp::dev::IDepthVisualParams | |||
virtual bool getDepthIntrinsicParam(yarp::os::Property &intrinsic) = 0; | |||
|
|||
/** | |||
* Get the accuracy of the depth measure in [meter] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
traversaro
reviewed
Sep 26, 2018
@@ -248,14 +249,14 @@ class YARP_dev_API yarp::dev::IDepthVisualParams | |||
virtual bool getDepthIntrinsicParam(yarp::os::Property &intrinsic) = 0; | |||
|
|||
/** | |||
* Get the accuracy of the depth measure in [meter] | |||
* @return the accuracy of the sensor in meters. | |||
* Get the minimum detectable variation in distance [meter] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
traversaro
approved these changes
Sep 26, 2018
Nicogene
added
Resolution: Merged
PR Status: Changelog - OK
This PR has a proper changelog entry
labels
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Devices
Component: Documentation
Component: Library - YARP_dev
PR Status: Changelog - OK
This PR has a proper changelog entry
PR Type: Bugfix
This PR fixes some bug
Resolution: Merged
Target: YARP v3.1.1
Type: Cleanup
Involves cleaning up some part of YARP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Moreover it clarifies the documentation of (
set/getDepthAccuracy
).Tests on real and fake device have been done.
Please review code.