Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the timeout check from RemoteControlBoard to the stateExtendedReader #1847

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Move the timeout check from RemoteControlBoard to the stateExtendedReader #1847

merged 3 commits into from
Apr 11, 2019

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Sep 4, 2018

This PR fixes #1833.

With @barbalberto we thought to add timeout check in all data kind streamed by *\stateExt:o ports not only for certain(e.g. getEncoder).

It is wip because it is more a proposal.
Please review code.

@Nicogene Nicogene added PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP Component: Library - YARP_dev Component: Devices Type: Cleanup Involves cleaning up some part of YARP Target: YARP v3.2.0 labels Sep 4, 2018
@Nicogene Nicogene requested a review from drdanz as a code owner September 4, 2018 12:19
barbalberto
barbalberto approved these changes Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@barbalberto barbalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nicogene
Copy link
Member Author

Any comments on this ? Shall we merge it?

cc @randaz81 @valegagge

@drdanz drdanz changed the base branch from devel to master April 11, 2019 07:10
@drdanz drdanz changed the title [WIP] Move the timeout check from RemoteControlBoard to the stateExtendedReader Move the timeout check from RemoteControlBoard to the stateExtendedReader Apr 11, 2019
randaz81
randaz81 approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@randaz81 randaz81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.
As an extra suggestion, TIMEOUT_EXT could be an optional parameter for remoteControlBoard, with default value = 0.5

@Nicogene
Copy link
Member Author

As an extra suggestion, TIMEOUT_EXT could be an optional parameter for remoteControlBoard, with default value = 0.5

Done in 7f20736 👍

Nicogene added 3 commits April 11, 2019 11:53
@Nicogene @drdanz
YARP_dev: move the logic of the timeout check from `RemoteControlBoar…
9a57eb3 
…d` to the `stateExtendedReader`.

In this way every read has a timeout check that before was only in few functions
like `getEncoders`. It fixes robotology#1833
@Nicogene @drdanz
Update release notes.
76be59b
@Nicogene @drdanz
RemoteControlBoard: cleanup and add timeout parameter from command line
ae54352
@drdanz drdanz merged commit a211f01 into robotology:master Apr 11, 2019
@Nicogene Nicogene deleted the fix1833 branch April 11, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barbalberto barbalberto barbalberto approved these changes

@randaz81 randaz81 randaz81 approved these changes

@drdanz drdanz drdanz approved these changes

Assignees
No one assigned
Labels
Component: Devices Component: Library - YARP_dev PR Type: Feat/Enh This PR adds some new feature or enhances some part of YARP Resolution: Merged Target: YARP v3.2.0 Type: Cleanup Involves cleaning up some part of YARP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remote_controlboard: Add timeout check in all data streamed by StateExt:o port
4 participants
@Nicogene @drdanz @randaz81 @barbalberto