Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated constructor in IJoypadEventDriven #1784

Merged
merged 2 commits into from
Jul 9, 2018

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented Jul 6, 2018

It fixes #1747

Please review code.

@Nicogene Nicogene self-assigned this Jul 6, 2018
@Nicogene Nicogene requested a review from drdanz July 6, 2018 15:48
Copy link
Collaborator

@barbalberto barbalberto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drdanz drdanz merged commit e2260fa into robotology:master Jul 9, 2018
@drdanz
Copy link
Member

drdanz commented Jul 9, 2018

Merged, thanks.

@Nicogene Nicogene deleted the fixDeprComstructor branch July 9, 2018 10:02
@jeljaik
Copy link
Collaborator

jeljaik commented Jul 9, 2018

Can we have this merged in devel?

@Nicogene
Copy link
Member Author

Nicogene commented Jul 9, 2018

@jeljaik done 👍

@jeljaik
Copy link
Collaborator

jeljaik commented Jul 9, 2018

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IJoypadEventDriven deprecated
4 participants