Fix YARP_COMPILE_EXECUTABLES build #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdanz
added
Component: CMake
PR Type: Bugfix
drdanz
changed the title
drdanz
changed the title
|
I just noticed that this fixes only CMake run, the build is still failing |
drdanz
changed the title
|
Should be fixed now |
|
And I was wrong 😿 |
Fixes build with YARP_COMPILE_EXECUTABLES=OFF The idl_tools component is now required in order to use yarp_idl_to_dir and yarp_add_idl.
drdanz
force-pushed
the
fix/YARP_COMPILE_EXECUTABLES
branch
from
7007d15 to
c41254e
Compare
|
ok, hopefully it should be fixed now... |
pattacini
added a commit
to robotology/cer
that referenced
this pull request
Jul 2, 2018
pattacini
added a commit
to robotology/icub-tutorials
that referenced
this pull request
Jul 2, 2018
pattacini
added a commit
to robotology/funny-things
that referenced
this pull request
Jul 2, 2018
pattacini
added a commit
to robotology/karma
that referenced
this pull request
Jul 2, 2018
pattacini
added a commit
to robotology/peripersonal-space
that referenced
this pull request
Jul 2, 2018
pattacini
added a commit
to robotology/stereo-vision
that referenced
this pull request
Jul 2, 2018
gsaponaro
added a commit
to gsaponaro/robot-affordances
that referenced
this pull request
Sep 12, 2018
gsaponaro
added a commit
to robotology/poeticon
that referenced
this pull request
Dec 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
idl_toolscomponent is now required in order to useyarp_idl_to_dirandyarp_add_idl.This component is included by default when COMPONENTS are not passed to
find_package(YARP)Moreover if the component is not included but either
yarp_idl_to_diroryarp_add_idlare used, a deprecation warning is printed, and the component is included, making it backwards compatible.Warning: requires latest YCM
devel, perhaps we should release YCM 0.9 before releasing YARP 3.0.1. Since I needed YCM form devel, I also took the chance to refactor a little, and move YCM to theexternfolder