InstallBasicPackageFiles: Support for CMake < 3.9

[drdanz]

This should fix #1727, but I don't have a system to test in this moment.

Can anyone with CMake 3.5 test this, please? @traversaro @PeterBowman @pattacini

[traversaro]

I think it is necessary also to fix https://github.com/robotology/yarp/blob/devel/cmake/template/YARPConfig.cmake.in#L142-L144 , otherwise the PR still gives the error :

[ 66%] Performing configure step for 'ICUB'
Not searching for unused variables given on the command line.
loading initial cache file /home/straversaro/src/robotology-superbuild/build/robotology/ICUB/CMakeFiles/YCMTmp/ICUB-cache.cmake
CMake Error at /usr/share/cmake-3.5/Modules/CMakeFindDependencyMacro.cmake:45 (message):
  Invalid arguments to find_dependency
Call Stack (most recent call first):
  /home/straversaro/src/robotology-superbuild/build/install/lib/cmake/YARP/YARPConfig.cmake:166 (find_dependency)
  CMakeLists.txt:37 (find_package)


-- Configuring incomplete, errors occurred!

[drdanz]

Right, I forgot about that, sorry...

[drdanz]

@traversaro last commit should fix it...

[Nicogene]

Configuration and generation of icub-main works now on my machine.
(But there is tons of deprecation message, I don't know if it is related)

$cmake --version
cmake version 3.5.1

I get this error when compiling FirmwareUpdater:

/usr/bin/ld: cannot find -lYARP::YARP_name

[pattacini]

@Nicogene I must have cleaned up icub-main by getting shot of YARP_INCLUDE_DIRS and YARP_DEFINES.

[Nicogene]

There was still one YARP_INCLUDE_DIRS in embObjLib.cmake
Fixed by robotology/icub-main@49f0f0b

[PeterBowman]

👍 Works for me, thanks.

[traversaro]

Working for me.

[Nicogene]

Since this build (https://travis-ci.org/robotology/yarp/builds/387342747?utm_source=github_status&utm_medium=notification), the thrift tests seems broken when yarp is compiled static. Anyone knows why ?
BTW we can merge this PR, the fail is not related.

[lrapetti]

Can we merge this PR?

[PeterBowman]

Since this build (https://travis-ci.org/robotology/yarp/builds/387342747?utm_source=github_status&utm_medium=notification), the thrift tests seems broken when yarp is compiled static. Anyone knows why ?

@Nicogene possibly related: #1715 (comment).

[PeterBowman]

Anyone knows why ?

@Nicogene an internal find_dependency(Eigen3) (via YARP_eigenConfig.cmake) call expects a Eigen3_FOUND variable, but it's spelled differently:

yarp/cmake/ycm-0.7.0/3rdparty/FindEigen3.cmake

Line 66 in e709b46

set(EIGEN3_FOUND ${EIGEN3_VERSION_OK})

I can replicate this with CMake 3.5 and static YARP at latest devel (e709b46) using own YCM modules. Downstream projects are configured once successfully (no EIGEN3_INCLUDE_DIR variable in cache, yet, thus we are in this block), then fail repeatedly with the same error (missing YARP_eigen because Eigen3 could not be found - here using EIGEN3_FOUND). See also PeterBowman@a5500ad, Travis.