Fix WBD config files broken in #173 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traversaro
approved these changes
Sep 13, 2023
gabrielenava
approved these changes
Sep 19, 2023
There was a problem hiding this comment.
thanks @HosameldinMohamed! I have tested with iCubGazeboV2_5 and iCubGazeboV3 and the device now runs also from the home folder.
|
Thanks all, merged.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the way the config files are called in #173, where I hard-coded the name of the estimator XML file to be called by the launch file. For example
launch-wholebodydynamics-icub-six-fts-sim.xmlcallswholebodydynamics-icub-external-six-fts-sim.xml.But looking at the CMake code, the launch files are installed with the generic name
launch-wholebodydynamics.xml, and the estimator files are installed asestimators/wholebodydynamics.xml, and it's installed for the following real robotsiCubDarmstadt01;iCubGenova02;iCubGenova04;iCubNancy01, and for the simulated robots:icubGazeboSim,iCubGazeboV2_5, andiCubGazeboV3.So I reverted to the correct line in this PR.