Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added walking configuration files for ergoCubGazeboV1 #134

Merged
merged 1 commit into from
Feb 10, 2023

Conversation

mebbaid
Copy link
Collaborator

@mebbaid mebbaid commented Feb 10, 2023

This PR allows for simulating the walking with the new ergoCub robot.
Related issue https://github.com/ami-iit/component_ergocub/issues/183

@GiulioRomualdi
Copy link
Member

Hi @mebbaid, thank you! For the time being, I would avoid adding hand_retargeting and joint_retargeting config files since they are not tested.

If you agree I can remove them and merge the PR.

Thank you for the effort

@mebbaid
Copy link
Collaborator Author

mebbaid commented Feb 10, 2023

Hi @mebbaid, thank you! For the time being, I would avoid adding hand_retargeting and joint_retargeting config files since they are not tested.

If you agree I can remove them and merge the PR.

Thank you for the effort

@GiulioRomualdi , for me it is fine, thanks you can go ahead

Copy link
Member

@GiulioRomualdi GiulioRomualdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging! Thank you @mebbaid

@GiulioRomualdi GiulioRomualdi merged commit bdbeeaf into robotology:master Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants