Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added states to googleSpeechProcess, googleSpeech and googleDialog. #38

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

lauracavaliere
Copy link
Contributor

In this PR we did some changes:

  • regarding googleSpeech and googleDialog: the /googleSpeech/state:o and the /googleDialog/state:o ports now show different error messages, depending on the type of failure. In particular, in case of network failure the port will output Failure_unavailable. All the possible cases are shown in this documentation;

  • regarding googleSpeechProcess: we added some states which describe the current situation of the service:

    • Busy, if the Google request has been launched and the user is waiting for the answer
    • Failure_<StatusCode>, if the Google service fails; the <StatusCode> depends on the type of failure
    • Done, when the Google request terminates successfully
    • Empty which means that the google request ended well but its response is empty

    These states are sent to the /googleSpeechProcess/state:o port only if the state is changed.

Copy link
Member

@vtikha vtikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! thank you @lauracavaliere @ilaria-carlini

@vtikha vtikha merged commit 0cd0895 into master Jun 10, 2021
@vtikha vtikha deleted the update_state_output branch June 10, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants