Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align configuration files to YARP devel #68

Merged
merged 20 commits into from
Jun 12, 2018

Conversation

S-Dafarra
Copy link
Contributor

Modifies the iCubGenova04 configuration files to be used with the latest version of YARP and iCub.

@S-Dafarra S-Dafarra requested review from randaz81 and valegagge May 17, 2018 10:58
@S-Dafarra
Copy link
Contributor Author

@valegagge @randaz81 Do you think we can merge this?

@valegagge
Copy link
Member

I think it is ok!
I have one only suggestion: in order to avoid to increase number of files, I suggest to delete old file abouts strain and rename file for strain2 in strain.

@S-Dafarra
Copy link
Contributor Author

S-Dafarra commented Jun 12, 2018

I have one only suggestion: in order to avoid to increase number of files, I suggest to delete old file abouts strain and rename file for strain2 in strain.

We are still testing those new features. For the time being I think it is better to keep both files and remove them in a next PR.

cc. @hu-yue @fjandrad

@S-Dafarra S-Dafarra merged commit 12ebad4 into devel Jun 12, 2018
@S-Dafarra S-Dafarra deleted the fix/develAlignement_iCubGenova04 branch February 19, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants