Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failing on ergoCubSN000 and iCubGenova09 with the latest yarp-3.8 #509

Closed
pattacini opened this issue May 11, 2023 · 11 comments
Closed
Assignees
Labels

Comments

@pattacini
Copy link
Member

pattacini commented May 11, 2023

I've just regenerated the docker image used by the CI relying on the yarp-3.8 branch rather than the v3.8.0 release (#508) and I'm getting the following errors:

dry-run_log_ergoCubSN000_dev.txt:

[ERROR] embObjMultipleFTsensors: BOARD left_arm-eb2-j0_1 (IP 10.0.1.2)   getTemperatureSensorMeasure() fails data for index: 0  not found

dry-run_log_iCubGenova09_dev.txt:

[ERROR] embObjMultipleFTsensors: BOARD left_leg-eb8-j3_5 (IP 10.0.1.8)   getTemperatureSensorMeasure() fails data for index: 0  not found

@traversaro, will robotology/yarp#2967 fix this problem too?

@pattacini pattacini added the bug label May 11, 2023
@pattacini pattacini self-assigned this May 11, 2023
@traversaro
Copy link
Member

traversaro commented May 11, 2023

This is more of an issue of embObjMultipleFTsensors, but indeed it will be mitigated by robotology/yarp#2967 .

It is related to the second fix from robotology/icub-main#871, and actually the reason why now it appears is that we fixed that bug. Before then, the value returned by embObjMultipleFTsensors::getNrOfTemperatureSensors was zero if no temperature measurement was received, and so no one called embObjMultipleFTsensors::getTemperatureSensorMeasure . robotology/yarp#2967 ensures that embObjMultipleFTsensors::getTemperatureSensorMeasure is not called if the status of the sensors is not MAS_OK, so it should ensure that this error does not appear.

However, after https://github.com/robotology/yarp/pull/2967/files you will see a different error in the terminal:

Failure in reading data from sensor %s, no data will be sent on the port.

So I am not sure if this is better from the point of view of CI.

@pattacini
Copy link
Member Author

pattacini commented May 11, 2023

Thanks for the clarification!

So I am not sure if this is better from the point of view of CI.

Does your last doubt mean that the driver per se in this configuration is not ready to be dry run at all?

@traversaro
Copy link
Member

It is not the driver, it is the multipleanalogsensorsserver that will print errors if no valid sensor measure is available. I wonder how other network wrapper server deal with this, perhaps they do not complain and just do not publish data if it is not available?

@pattacini
Copy link
Member Author

Yep, with the term driver I was referring to the whole stack.

This can be a major issue for the CI. In the worst case, I may try to disable these layers during the CI as done for others, but it'd be a pity after all.

We can discuss it.
Thanks

@traversaro
Copy link
Member

I think it could make sense if we agree on a dryrun or similar parameter to pass to every device so that every device is aware and suppress errors that do not make sense to print during a dryrun (such as errors because no sensor message arrived).

@pattacini
Copy link
Member Author

pattacini commented May 12, 2023

Temporary disabled the failing tests in the CI via 93d60a4.

Failing tests can be still run by:

ctest -L [failing|all]

cc @traversaro

@pattacini
Copy link
Member Author

pattacini commented May 12, 2023

ea68236 and 4d2081b streamline the handling of skipped tests.

Now, to run locally or on Gitpod skipped tests, one needs to do:

ctest -L skip

Tests to be skipped are specified in:

@pattacini
Copy link
Member Author

pattacini commented May 12, 2023

Aligned T2T w/ @traversaro: all good then 👍🏻
The error message is not causing any harm to the CI.

The CI failed because of the yarprobotinterface crash, which will be solved via robotology/yarp#2967.

Note
Put in review.

Warning
Remember to reinstate the skipped tests before closing.

@pattacini
Copy link
Member Author

pattacini commented May 15, 2023

The PR robotology/yarp#2967 has been merged although the dry-run still fails with the following log:

[ERROR] yarprobotinterface intercepted a segmentation fault caused by a faulty plugin:
[ERROR] /dependencies/install/lib/yarp/yarp_multipleanalogsensorsserver.so(+0x13f69) [0x7f42b401cf69]

@traversaro is on it.


The docker image has been regenerated:

@traversaro
Copy link
Member

@traversaro is on it.

My bad, apparently I forgot to push some changes, the fix is in robotology/yarp#2970 .

@pattacini
Copy link
Member Author

Thanks!

mfussi66 pushed a commit to mfussi66/robots-configuration that referenced this issue Jun 19, 2023
MSECode pushed a commit to valegagge/robots-configuration that referenced this issue Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants