Handle different names of libdc1394 package in different distributions #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
reviewed
Aug 25, 2021
| then | ||
| : | ||
| else | ||
| apt-get install -y nlohmann-json3-dev |
There was a problem hiding this comment.
Which version of the library is it installed? Because now yarp-telemetry needs the v3.10.0
There was a problem hiding this comment.
The specific version depends on the specific ubuntu version, see https://repology.org/project/nlohmann-json/versions . However, at the moment not even Debian Unstable (sid) has 3.10.0 . I think we can continue to use the FetchContent-provided nlohmann-json in yarp-telemetry for some time now, this PR does not change anything from that point of view.
|
The CI is now green. |
Nicogene
approved these changes
Aug 25, 2021
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #854 . I took the occasion to also move in
install_apt_dependencies.shthe installation of nlohmman-json library.