Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostic daemon #436

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Conversation

Nicogene
Copy link
Member

This PR add the diagnostidaemon to the ICUB_HEAD profile.

It will be draft(and I think not passing CI) until diagnostic-daemon won't be public

@Nicogene Nicogene requested a review from traversaro July 27, 2020 12:52
CMakeLists.txt Outdated Show resolved Hide resolved
@Nicogene Nicogene force-pushed the feat/addDiagnosticDaemon branch from cacb76a to bbe24b2 Compare July 28, 2020 08:43
@Nicogene Nicogene marked this pull request as ready for review July 28, 2020 08:44
It needs icub_firmware_shared 1.16.100
@Nicogene Nicogene self-assigned this Jul 28, 2020
@Nicogene
Copy link
Member Author

@traversaro the build of macOS is failing due to :

/diagnosticdaemon.build/Release/diagnosticdaemon.build/Objects-normal/x86_64/diagnosticdaemon_dependency_info.dat -o /Users/runner/work/robotology-superbuild/robotology-superbuild/build/robotology/diagnosticdaemon/Release/diagnosticdaemon
2020-07-28T12:51:20.1520890Z ld: library not found for -lstdc++fs
2020-07-28T12:51:20.1521900Z clang: error: linker command failed with exit code 1 (use -v to see invocation)
2020-07-28T12:51:20.1523300Z 
2020-07-28T12:51:20.1555710Z ** BUILD FAILED **
2020-07-28T12:51:20.1557240Z 

I added that library for using <experimental/filesystem> since <filesystem> is available only since gcc 8 and Ubuntu 18.04 has gcc 7.5.

It is possible to add the macOs compatibility but I don't think it would be worthy.
Once we will drop Ubuntu 18.04 we will use <filesystem> and we should have the compatibility.

Is it ok for you if for now I add if(NOT APPLE) in CMakeLists.txt?

@traversaro
Copy link
Member

Is it ok for you if for now I add if(NOT APPLE) in CMakeLists.txt?

Ok, please add a comment mention that this is necessary because of #439 .

@Nicogene Nicogene requested a review from traversaro July 28, 2020 13:22
@Nicogene Nicogene merged commit e1ab98d into robotology:master Jul 28, 2020
@Nicogene Nicogene deleted the feat/addDiagnosticDaemon branch July 28, 2020 13:28
@traversaro
Copy link
Member

Hi @Nicogene, this PR broke the CI, in particular on Release 2020.08, can you check it? In general when I "Approve" a PR I mean as "We can merge it as long as the CI passes".

@traversaro
Copy link
Member

Hi @Nicogene, this PR broke the CI, in particular on Release 2020.08, can you check it? In general when I "Approve" a PR I mean as "We can merge it as long as the CI passes".

Actually I was wrong, the regression in there is not related to that PR, see #441 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants