Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for building on Windows with Ninja #1682

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix support for building on Windows with Ninja #1682

merged 2 commits into from
Aug 10, 2024

Conversation

traversaro
Copy link
Member

Fix #1083 .

To do so, it was necessary to fix support for building shared libraries and disabling static libraries in osqp 0.6.3, this was already done since a lot of time in osqp master, but as long as we do not get a release of osqp, we continue to use osqp 0.6.3 . The related commits are:

@traversaro
Copy link
Member Author

For now I will not update the docs, as anyhow ninja + superbuild has its own problems (see https://discourse.cmake.org/t/efficiency-issues-with-externalproject-sub-builds-under-ninja and https://gitlab.kitware.com/cmake/cmake/-/issues/22145), but it may be useful to know this for faster builds on Windows, fyi @S-Dafarra @mebbaid or anyone else that actually uses the superbuild on Windows (not sure who).

@traversaro traversaro merged commit ce44714 into master Aug 10, 2024
25 checks passed
@traversaro traversaro deleted the fix1083 branch August 10, 2024 11:09
@traversaro
Copy link
Member Author

At least in CI, Ninja builds take ~half of the time of Visual Studio builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single-Config Ninja build fails on Windows April 2022
1 participant