Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buildmanif: Explicitly compile with C++17 #1437

Merged
merged 2 commits into from
Jul 10, 2023
Merged

Buildmanif: Explicitly compile with C++17 #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f12e451
Buildmanif: Explicitly compile with C++17
traversaro Jul 5, 2023
680b758
Bump manif to 0.0.4.103
traversaro Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cmake/Buildmanif.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,16 @@ else()
set(BUILD_PYTHON_BINDINGS OFF)
endif()

# We pass CMAKE_CXX_STANDARD=17 as we encountered problems when using -march=native
# and mixing libraries compiled with C++11 and C++17, see
# https://github.com/artivis/manif/issues/274
ycm_ep_helper(manif TYPE GIT
STYLE GITHUB
REPOSITORY artivis/manif.git
TAG master
COMPONENT external
FOLDER src
CMAKE_ARGS -DBUILD_TESTING:BOOL=OFF -DBUILD_EXAMPLES:BOOL=OFF -DBUILD_PYTHON_BINDINGS:BOOL=${BUILD_PYTHON_BINDINGS} -DMANIFPY_PKGDIR:PATH=${YCM_EP_INSTALL_DIR}/${ROBOTOLOGY_SUPERBUILD_PYTHON_INSTALL_DIR})
CMAKE_ARGS -DCMAKE_CXX_STANDARD=17 -DBUILD_TESTING:BOOL=OFF -DBUILD_EXAMPLES:BOOL=OFF -DBUILD_PYTHON_BINDINGS:BOOL=${BUILD_PYTHON_BINDINGS} -DMANIFPY_PKGDIR:PATH=${YCM_EP_INSTALL_DIR}/${ROBOTOLOGY_SUPERBUILD_PYTHON_INSTALL_DIR})

set(manif_CONDA_PKG_NAME manif)
set(manif_CONDA_PKG_CONDA_FORGE_OVERRIDE ON)
Expand Down
2 changes: 1 addition & 1 deletion cmake/ProjectsTagsStable.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ endmacro()
# External projects
set_tag(osqp_TAG v0.6.3)
set_tag(manif_REPOSITORY robotology-dependencies/manif.git)
set_tag(manif_TAG 0.0.4.102)
set_tag(manif_TAG 0.0.4.103)
set_tag(qhull_TAG 2020.2)
set_tag(CppAD_TAG 20230000.0)
set_tag(proxsuite_TAG v0.3.6)
Expand Down
2 changes: 1 addition & 1 deletion cmake/ProjectsTagsUnstable.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ endmacro()
# External projects
set_tag(osqp_TAG v0.6.3)
set_tag(manif_REPOSITORY robotology-dependencies/manif.git)
set_tag(manif_TAG 0.0.4.102)
set_tag(manif_TAG 0.0.4.103)
set_tag(qhull_TAG 2020.2)
set_tag(CppAD_TAG 20230000.0)
set_tag(proxsuite_TAG v0.3.6)
Expand Down
2 changes: 1 addition & 1 deletion releases/latest.releases.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repositories:
manif:
type: git
url: https://github.com/robotology-dependencies/manif.git
version: 0.0.4.102
version: 0.0.4.103
qhull:
type: git
url: https://github.com/qhull/qhull.git
Expand Down