-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda binary packages generation in releases/2022.05 branch #1146
Conversation
Situation after the latest test in https://github.com/robotology/robotology-superbuild/runs/6762125564 . WindowsWorks fine! Linux
This will be fixed by adding some code to ensure that opengl packages are installed. macOS
Strange error, not sure what is happening, probably the libopencv pinning coming from conda-forge is wrong (but why this appears only here?). |
The conda generation is finally fixed: https://github.com/robotology/robotology-superbuild/actions/runs/2453544472 . |
Final test, run as part of release with generation of metapackages |
metapackages are failing with:
basically the code that extracts the versions from the tag is not smart enough to handle |
Note the most handsome solution, but traversaro@a577ed6 should fix the problem. New test job: https://github.com/traversaro/robotology-superbuild/actions/runs/2459845013 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we release 2022.05.1 maybe we can also add the release of icub-models since the wrist yaw issue has been fixed?
Yes, this is a good idea! |
Now the packages generation is working fine on macOS and Linux, while on Windows we are back to #1094, probably because something changed in the pinned releases on conda-forge, and now the solving dependencies moment takes more. At this point, I think we can proceed with 2022.05.1 with Linux and macOS packages, and work later on getting Windows packages. |
This PR targets the
releases/2022.05
so that when the conda binary packages generation is fixed, we can merge it and release v2022.05.1 . Then, we could cherry-pick this changes in master as well.See the commit descriptions for the detailed fixes.
Fix #1140
Fix #1139