Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda binary packages generation in releases/2022.05 branch #1146

Merged
merged 7 commits into from
Jun 9, 2022

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Jun 5, 2022

This PR targets the releases/2022.05 so that when the conda binary packages generation is fixed, we can merge it and release v2022.05.1 . Then, we could cherry-pick this changes in master as well.

See the commit descriptions for the detailed fixes.

Fix #1140
Fix #1139

@traversaro traversaro changed the title Fix conda binary packages generation in releases/2022.05 branch [WIP] Fix conda binary packages generation in releases/2022.05 branch Jun 5, 2022
@traversaro traversaro closed this Jun 6, 2022
@traversaro traversaro reopened this Jun 6, 2022
@traversaro
Copy link
Member Author

Situation after the latest test in https://github.com/robotology/robotology-superbuild/runs/6762125564 .

Windows

Works fine!

Linux

2022-06-06T22:47:49.8965266Z HEAD is now at e51f925 Merge pull request #18 from ami-iit/trackers
2022-06-06T22:47:53.8843760Z CMake Error at /usr/share/miniconda/envs/test/conda-bld/yarp-device-openxrheadset_1654555383682/_build_env/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
2022-06-06T22:47:53.8844709Z   Could NOT find OpenGL (missing: OPENGL_opengl_LIBRARY OPENGL_glx_LIBRARY
2022-06-06T22:47:53.8845141Z   OPENGL_INCLUDE_DIR)
2022-06-06T22:47:53.8845507Z Call Stack (most recent call first):
2022-06-06T22:47:53.8846412Z   /usr/share/miniconda/envs/test/conda-bld/yarp-device-openxrheadset_1654555383682/_build_env/share/cmake-3.23/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
2022-06-06T22:47:53.8847527Z   /usr/share/miniconda/envs/test/conda-bld/yarp-device-openxrheadset_1654555383682/_build_env/share/cmake-3.23/Modules/FindOpenGL.cmake:443 (FIND_PACKAGE_HANDLE_STANDARD_ARGS)
2022-06-06T22:47:53.8848581Z   build/_deps/glfont-src/CMakeLists.txt:14 (find_package)

This will be fixed by adding some code to ensure that opengl packages are installed.

macOS

2022-06-06T22:17:45.2987760Z Mamba failed to solve:
2022-06-06T22:17:45.2988300Z  - gazebo 11.9.*
2022-06-06T22:17:45.2988560Z  - yarp
2022-06-06T22:17:45.2988800Z  - libcxx >=13.0.1
2022-06-06T22:17:45.2989030Z  - dartsim
2022-06-06T22:17:45.2989290Z  - libopencv 4.5.3.*
2022-06-06T22:17:45.2989510Z 
2022-06-06T22:17:45.2989580Z with channels:
2022-06-06T22:17:45.2989780Z 
2022-06-06T22:17:45.2989910Z The reported errors are:
2022-06-06T22:17:45.2990810Z - Encountered problems while solving:
2022-06-06T22:17:45.2991410Z -   - package yarp-3.7.0-py38h335a622_54 requires qt-main >=5.15.2,<5.16.0a0, but none of the providers can be installed
2022-06-06T22:17:45.2992220Z - 
2022-06-06T22:17:45.2992530Z conda-forge/noarch        
2022-06-06T22:17:45.2992820Z conda-forge/osx-64        
2022-06-06T22:17:45.2993030Z usr/local/miniconda/envs  
2022-06-06T22:17:45.2993260Z usr/local/miniconda/envs  
2022-06-06T22:17:45.2993450Z usr/local/miniconda/envs  
2022-06-06T22:17:45.2993660Z usr/local/miniconda/envs  
2022-06-06T22:17:45.3104480Z Traceback (most recent call last):
2022-06-06T22:17:45.3125480Z   File "/usr/local/miniconda/envs/test/lib/python3.8/site-packages/boa/cli/mambabuild.py", line 123, in mamba_get_install_actions
2022-06-06T22:17:45.3126210Z     solution = solver.solve_for_action(_specs, prefix)
2022-06-06T22:17:45.3127040Z   File "/usr/local/miniconda/envs/test/lib/python3.8/site-packages/boa/core/solver.py", line 234, in solve_for_action
2022-06-06T22:17:45.3163090Z     t = self.solve(specs)
2022-06-06T22:17:45.3352910Z   File "/usr/local/miniconda/envs/test/lib/python3.8/site-packages/boa/core/solver.py", line 216, in solve
2022-06-06T22:17:45.3460020Z     raise RuntimeError("Solver could not find solution." + error_string)
2022-06-06T22:17:45.3696610Z RuntimeError: Solver could not find solution.Mamba failed to solve:
2022-06-06T22:17:45.3759310Z  - gazebo 11.9.*
2022-06-06T22:17:45.3760060Z  - yarp
2022-06-06T22:17:45.3760620Z  - libcxx >=13.0.1
2022-06-06T22:17:45.3761170Z  - dartsim
2022-06-06T22:17:45.3761710Z  - libopencv 4.5.3.*
2022-06-06T22:17:45.3762110Z 
2022-06-06T22:17:45.3762400Z with channels:
2022-06-06T22:17:45.3762750Z 
2022-06-06T22:17:45.3763060Z The reported errors are:
2022-06-06T22:17:45.3763670Z - Encountered problems while solving:
2022-06-06T22:17:45.3764480Z -   - package yarp-3.7.0-py38h335a622_54 requires qt-main >=5.15.2,<5.16.0a0, but none of the providers can be installed

Strange error, not sure what is happening, probably the libopencv pinning coming from conda-forge is wrong (but why this appears only here?).

@traversaro
Copy link
Member Author

Linux build should be fixed by ee8d8ed while macOS should be fixed by 7b24012 .

@traversaro
Copy link
Member Author

The conda generation is finally fixed: https://github.com/robotology/robotology-superbuild/actions/runs/2453544472 .

@traversaro traversaro changed the title [WIP] Fix conda binary packages generation in releases/2022.05 branch Fix conda binary packages generation in releases/2022.05 branch Jun 7, 2022
@traversaro
Copy link
Member Author

Final test, run as part of release with generation of metapackages robotology-distro and robotology-distro-all: https://github.com/traversaro/robotology-superbuild/actions/runs/2456256129 .

@traversaro
Copy link
Member Author

Final test, run as part of release with generation of metapackages robotology-distro and robotology-distro-all: https://github.com/traversaro/robotology-superbuild/actions/runs/2456256129 .

metapackages are failing with:

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested openxr-sdk release-1.0.23.*

basically the code that extracts the versions from the tag is not smart enough to handle release-1.0.23 format used by openxr.

@traversaro
Copy link
Member Author

traversaro commented Jun 8, 2022

Final test, run as part of release with generation of metapackages robotology-distro and robotology-distro-all: https://github.com/traversaro/robotology-superbuild/actions/runs/2456256129 .

metapackages are failing with:

The reported errors are:
- Encountered problems while solving:
-   - nothing provides requested openxr-sdk release-1.0.23.*

basically the code that extracts the versions from the tag is not smart enough to handle release-1.0.23 format used by openxr.

Note the most handsome solution, but traversaro@a577ed6 should fix the problem. New test job: https://github.com/traversaro/robotology-superbuild/actions/runs/2459845013 .

Copy link
Member

@Nicogene Nicogene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we release 2022.05.1 maybe we can also add the release of icub-models since the wrist yaw issue has been fixed?

@traversaro
Copy link
Member Author

If we release 2022.05.1 maybe we can also add the release of icub-models since the wrist yaw issue has been fixed?

Yes, this is a good idea!

@traversaro
Copy link
Member Author

Note the most handsome solution, but traversaro@a577ed6 should fix the problem. New test job: https://github.com/traversaro/robotology-superbuild/actions/runs/2459845013 .

Now the packages generation is working fine on macOS and Linux, while on Windows we are back to #1094, probably because something changed in the pinned releases on conda-forge, and now the solving dependencies moment takes more. At this point, I think we can proceed with 2022.05.1 with Linux and macOS packages, and work later on getting Windows packages.

@traversaro traversaro merged commit 1308f97 into releases/2022.05 Jun 9, 2022
@traversaro traversaro deleted the fix1140 branch June 9, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants