Add dependency of walking-controllers on bipedal-locomotion-framework #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dependency on BipedalLocomotionFramework was added in robotology/walking-controllers#97, not sure why it started to fail just now. |
The reason is that we were using the |
lrapetti
approved these changes
Feb 4, 2022
There was a problem hiding this comment.
Thanks for the fix @traversaro (I have just experienced this issue)
Thanks for the review, merging now. |
Nicogene
pushed a commit
to Nicogene/robotology-superbuild
that referenced
this pull request
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
bipedal-locomotion-frameworkis only compiled ifROBOTOLOGY_ENABLE_DYNAMICS_FULL_DEPScomponent is enabled, to make sure that everything works as expected we need to movewalking-controllersunder theDYNAMICS_FULL_DEPScomponent.Fix #1010 .