Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong name for the Build<package>.cmake for matio-cpp #678

Closed
Nicogene opened this issue Apr 6, 2021 · 3 comments
Closed

Wrong name for the Build<package>.cmake for matio-cpp #678

Nicogene opened this issue Apr 6, 2021 · 3 comments
Assignees
Labels

Comments

@Nicogene
Copy link
Member

Nicogene commented Apr 6, 2021

The cmake name of matio-cpp is actually matioCpp, then this https://github.com/robotology/robotology-superbuild/blob/master/cmake/Buildmatio-cpp.cmake should be named BuildmatioCpp.cmake and matio-cpp has to be replaced in other find_or_build_package calls.

cc @traversaro @S-Dafarra

@Nicogene Nicogene added the bug label Apr 6, 2021
@S-Dafarra
Copy link
Collaborator

Is it ok to have the two names different?

@traversaro
Copy link
Member

Good point!

@traversaro
Copy link
Member

Is it ok to have the two names different?

In the normal workflow that we typically use is not a big difference, having two different names may be problematic if you want to configure the superbuild to use an external matioCpp as find_or_build_package(matio-cpp) will not actually look for the matioCpp package.

Nicogene added a commit that referenced this issue Apr 7, 2021
@Nicogene Nicogene self-assigned this Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants