-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to recent vcpkg version #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In particular: * Use a recent commit of vcpkg, microsoft/vcpkg@28ab0b1 that contains microsoft/vcpkg#10644 * Update qt5 to build with the `latest` feature, that install qt 5.14 that should be the first version of qt completely relocatable ( https://www.qt.io/blog/qt-is-relocatable ) * Substitute opencv3 with opencv, that install opencv4 * Install also `asio`, `boost-asio`, `boost-process`, `boost-dll`, `boost-filesystem` and `boost-system`, to fix #7 * As the newer version of vcpkg are affected by the bug microsoft/vcpkg#10119, clone the `robotology-vcpkg-binary-ports` repo in `C:/robotology`, so that it will be contained in the same archive used to distribute the vcpkg dependencies .
The CI is failing due to a change of hash in the ode tarball served by bitbucket. It will be fixed by microsoft/vcpkg#11029 . |
The PR seems to be finally fine and ready to review @Nicogene . |
Nicogene
approved these changes
Apr 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
latest
feature, that install qt 5.14 that should be the first version of qt completely relocatable ( https://www.qt.io/blog/qt-is-relocatable )asio
,boost-asio
,boost-process
,boost-dll
,boost-filesystem
andboost-system
, to fix Add boost as vcpkg dependency #7robotology-vcpkg-binary-ports
repo inC:/robotology
, so that it will be contained in the same archive used to distribute the vcpkg dependencies . The documentation has been updated to cover this.qt5-quickcontrols
to fix yarpview does not start when installed from robotology-full-installer-2020.02-win64 robotology-superbuild#354The generated libraries will be tested to see if they solve robotology/robotology-superbuild#354 and robotology/robotology-superbuild#355 .