icub-model-test: Remove use of deprecated iDynTree method #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KinDynComputations::loadRobotModelFromFile has been deprecated in iDynTree 1 and removed in iDynTree 2.
|
This is necessary to ensure that the this repo continue to work fine with iDynTree 2. |
GiulioRomualdi
approved these changes
Nov 4, 2020
There was a problem hiding this comment.
Hi @traversaro. I'm not an expert of icub-model-generator. But I think it's fine
|
Actually the build is failing because we are using a really old iDynTree. Better to fix #161 and then revisit this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KinDynComputations::loadRobotModelFromFile has been deprecated in iDynTree 1 and removed in iDynTree 2.