Fix HumanLogger not working when logging just one quantity #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @claudia-lat |
lrapetti
approved these changes
Feb 15, 2023
RiccardoGrieco
force-pushed
the
fix/human_logger
branch
from
41b5601 to
b7734af
Compare
lrapetti
approved these changes
Feb 16, 2023
|
Thanks @lrapetti, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The periodic thread (e.g. the
run()function) in human logger is started inside theattachAllmethod.Turns out that, since the device implements both
IWrapperandIMultipleWrapper, the first one is preferred when the list of devices to attach contains only one of them (see here).In such case, only the
attach()method belonging toIWrapperis called.In our case, this happens when using the logging of only one between the kinematics and dynamics data.
This PR is to solve this issue.