-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iCubGazeboV2_5 model #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would have avoided the indentation only file change 54e430a that will complexifies quick comparison against icub-models's models in the future and porting changes from this repo to icub-models, but I guess this is not blocking the PR.
It speeds up development though :) I didn't consider comparisons, you're right. It's too late now to roll back, a rebase would not work in this case. |
Just to understand, why four spaces indent speeds up the development over two spaces indent? Note that those files were already indented programmatically using the |
It's not the indentation that speeds up the development. Simply, when I save in my setup all files get reformatted, and it happened that I had the 4 spaces enabled by default. |
As a workaround, I can format back the file to 2 spaces. One extra commit would not harm :) |
As you prefer, you can even just re-format back when we will need comparisons. |
d91f4fa
to
5b22b21
Compare
This folder will be installed multiple times for all models that needs the meshes. It allows hosting a single folder in the repository that is duplicated in the install step.
It simplifies comparing the file with the original model
5b22b21
to
795e7a8
Compare
The iCub model has been taken from iCubGazeboV2_5/model.urdf and adapted to work in Ignition Gazebo.