Skip to content
This repository has been archived by the owner on Jan 5, 2025. It is now read-only.

Cleanup PUBLIC and PRIVATE link dependencies #17

Open
traversaro opened this issue Mar 8, 2021 · 0 comments
Open

Cleanup PUBLIC and PRIVATE link dependencies #17

traversaro opened this issue Mar 8, 2021 · 0 comments

Comments

@traversaro
Copy link
Member

At the moment, the libraries installed by diagnostic-daemon link all their dependency without any specifier (see

target_link_libraries(${PROJECT_NAME} ${Common_LIBRARIES}
), that means that all those libraries are linked as PRIVATE . However, libraries that are used in the public headers of the library (such as Boost, see
#define BOOST_ERROR_CODE_HEADER_ONLY
) should be linked as PUBLIC dependencies, as they also need to be linked by downstream binaries that link to the library.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant