-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push ScenarI/O APIs to the nightly channel #185
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split all gympp resources to a separated folder
ScenarI/O: SCENe interfAces for Robot Input / Output - New Ignition Gazebo ECM APIs
Substituted by a mutex stored in a ECM component
In this case, existing entities of the world could not be marked as New in the ECM.
- The ECM pointer is the same even if multiple worlds are part of the simulation - Removed old synchronization logic
Move and update Ignition plugins to work with ScenarI/O
…ndings Generate idiomatic undercase Python bindings
diegoferigo
requested review from
traversaro,
paolo-viceconte and
raffaello-camoriano
May 2, 2020 12:14
I guess this change were already reviewed with PR to the |
traversaro
approved these changes
May 2, 2020
This PR is the sum of all the others PR that you reviewed in the past few weeks that were targeting the |
Update Github Actions Workflows and Docker Images
This was referenced May 5, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here we are. This PR will merge the new bindings to
devel
, and this means that they will be released in our nightly channel 🎉Last steps:
gym_ignition_data
package, replaced by gym-ignition-models Remove gym_ignition_data #190gympp{Error,Warning,Message,Info}
withs{Error,Warning,Message,Info}
Rename log macros #192Note: In the README the installation instructions for the nightly channel are not accurate. In this moment we require an installation of Ignition Robotics from sources since we need few PRs that have to be merged upstream. Since this is only a transition, for the moment I didn't modify them.