Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push ScenarI/O APIs to the nightly channel #185

Merged
merged 244 commits into from
May 2, 2020
Merged

Push ScenarI/O APIs to the nightly channel #185

merged 244 commits into from
May 2, 2020

Conversation

diegoferigo
Copy link
Collaborator

@diegoferigo diegoferigo commented Apr 27, 2020

Here we are. This PR will merge the new bindings to devel, and this means that they will be released in our nightly channel 🎉


Last steps:

Note: In the README the installation instructions for the nightly channel are not accurate. In this moment we require an installation of Ignition Robotics from sources since we need few PRs that have to be merged upstream. Since this is only a transition, for the moment I didn't modify them.

Split all gympp resources to a separated folder
ScenarI/O: SCENe interfAces for Robot Input / Output - New Ignition Gazebo ECM APIs
Substituted by a mutex stored in a ECM component
In this case, existing entities of the world could not be marked as New in the ECM.
- The ECM pointer is the same even if multiple worlds are part of the simulation
- Removed old synchronization logic
Move and update Ignition plugins to work with ScenarI/O
@diegoferigo diegoferigo marked this pull request as ready for review May 2, 2020 12:14
@traversaro
Copy link
Contributor

I guess this change were already reviewed with PR to the refactoring branch, right?

@diegoferigo
Copy link
Collaborator Author

This PR is the sum of all the others PR that you reviewed in the past few weeks that were targeting the refactoring branch. The only real addition is the README commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants