Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote compile-time USE_LMA option to runtime usage in KdlSolver #155

Closed
PeterBowman opened this issue Jun 12, 2018 · 8 comments
Closed
Assignees

Comments

@PeterBowman
Copy link
Member

As spoken with @jgvictores, it would be nice to convert the USE_LMA CMake option (handled as a preprocessor definition, ref) into a YARP RF option loadable along with the device itself (via command line or programatically).

Not sure about the capitalization: is --useLMA ok? And sticking to current defaults (this option is set to OFF), such property wouldn't accept any value and the lack of a --useLMA shall mean use the Newton-Raphson algorithm.

@jgvictores
Copy link
Member

I was thinking more of an --ik lma, leaving the future open for more than 2 options.

@PeterBowman
Copy link
Member Author

Hm, we'd have to develop our own implementation of KDL::ChainIkSolverPos as there are only three of them available in the KDL framework (or two, just taking into account joint limits): LMA, NR, NR-JL (ref).

Question: missing --ik option = error? Assume NR-JL as default value otherwise?

@jgvictores
Copy link
Member

I'd almost default to lma. : )

BTW, I recall a fork with a LMA_JL too, but haven't been able to find it. However, here's something that I have found: KDL::ChainIkSolverPos_LMA_JL_Mimic Class, chainiksolver_pos_lma_jl_mimic.h.

@jgvictores
Copy link
Member

PS: Just re-discovered orocos/orocos_kinematics_dynamics#35 (Added joint limits to ChainIkSolverPos_LMA): apparently closed but never merged...

@jgvictores
Copy link
Member

Regarding KDL::ChainIkSolverPos_LMA_JL_Mimic, so much WET development would deserve some effort for a PR on KDL (unless I'm really missing something).

@PeterBowman
Copy link
Member Author

Done at 8c82f75.

@jgvictores
Copy link
Member

Note to self: check out what is done in https://github.com/ros-industrial-consortium/descartes (has refs to both KDL and ikfast).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants