Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default output dir in the config snippet #829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pasikokko
Copy link

Adding the output folder in the launch configuration snippets, to make sure output files are always generated in the same folder, despite how you start the robot.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
All committers have signed the CLA.

@fabioz
Copy link
Collaborator

fabioz commented Dec 5, 2022

If it should be the same dir it should probably use the ${workspaceFolder} variable so that it doesn't rely on the cwd.

Also, please run the codegen_package.py so that the package.json file is regenerated with those updated values.

@pasikokko
Copy link
Author

Actually, the output dir should be inside the robot folder, but I haven't figured out how to configure that in generic way, so that it would work for many robots in the workspace

@fabioz
Copy link
Collaborator

fabioz commented Dec 5, 2022

Humm, that's really trickier. The problem is that the Robot Framework Language Server doesn't really have much information on the actual structure of Robocorp Code in this case.

I'll have to think a bit more on how to solve this properly as this connection needs to be thought a bit better in this case. Can you create a ticket in: https://github.com/robocorp/robotframework-lsp/issues with the actual use case?

@pasikokko
Copy link
Author

I'll do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants