Skip to content

Commit

Permalink
bugfix: exclude transitive logback dependencies
Browse files Browse the repository at this point in the history
A logback slf4j binding is being pulled in via zookeeper causing issues
at runtime because we have two slf4j bindings available. Slf4j chooses
one implementation and it can pick logback, which is unexpected.

Fixes linkedin#2174

Signed-off-by: Robert Young <[email protected]>
  • Loading branch information
robobario committed Jul 23, 2024
1 parent f23332a commit 6b862d1
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ project(':cruise-control-core') {
configurations.all {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
exclude group: 'log4j', module: 'log4j'
exclude group: 'ch.qos.logback'
}
implementation "org.slf4j:slf4j-api:1.7.36"
implementation "org.apache.logging.log4j:log4j-slf4j-impl:2.17.2"
Expand Down Expand Up @@ -267,6 +268,7 @@ project(':cruise-control') {
configurations.all {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
exclude group: 'log4j', module: 'log4j'
exclude group: 'ch.qos.logback'
}

api project(':cruise-control-metrics-reporter')
Expand Down Expand Up @@ -437,6 +439,7 @@ project(':cruise-control-metrics-reporter') {
configurations.all {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
exclude group: 'log4j', module: 'log4j'
exclude group: 'ch.qos.logback'
}

implementation "org.slf4j:slf4j-api:1.7.36"
Expand Down

0 comments on commit 6b862d1

Please sign in to comment.