Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular v.8 rc4 packages #245

Closed
wants to merge 1 commit into from
Closed

Angular v.8 rc4 packages #245

wants to merge 1 commit into from

Conversation

bogacg
Copy link

@bogacg bogacg commented May 23, 2019

Please review as a preparation to Angular v.8 launch.
I did update package versions, test, build and had some warnings/errors therefore made some minor changes accordingly.

@robisim74 robisim74 mentioned this pull request May 24, 2019
build.js Show resolved Hide resolved
@robisim74
Copy link
Owner

@bogacg Thanks for this pr. But as I said, I'll release a new version when official Angular v8 will be released. However, I will consider the modifications of this pr.

@bogacg
Copy link
Author

bogacg commented May 25, 2019

Yes, waiting for official release is the right move.

@robisim74
Copy link
Owner

I'm closing this pr, since I updated directly keeping it in mind. Thanks again!

@robisim74 robisim74 closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants