Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prefixing for grid-column/row-span #177

Closed
wants to merge 1 commit into from

Conversation

etripier
Copy link
Contributor

It turns out that using an integer value for msGrid(Column|Row)Span causes the style to be interpreted as a unitless length value, which means it ends up as ${value}px instead of just ${value}. Unfortunately, that's not what we want - we expect this to refer to a line position on the grid.

I also took the opportunity to fix #176, although I think the conditions for producing that error are far off the beaten path.

@etripier
Copy link
Contributor Author

@robinweser @lencioni Hello there! Would you please review this when you have time?

@lencioni
Copy link
Contributor

I'm confused why ms is a special case for this package. I'm wondering if the root problem you are seeing is somewhere else?

@robinweser
Copy link
Owner

@etripier Hmm. Seems more like an issue with the underlying styling library?

@etripier etripier closed this Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'split' of undefined (error with new Grid stuff)
3 participants