Fix prefixing for grid-column/row-span #177
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that using an integer value for
msGrid(Column|Row)Span
causes the style to be interpreted as a unitless length value, which means it ends up as${value}px
instead of just${value}
. Unfortunately, that's not what we want - we expect this to refer to a line position on the grid.I also took the opportunity to fix #176, although I think the conditions for producing that error are far off the beaten path.