Shake hands #16
Open
Shake hands #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure no problem! Thanks for the kind words 🙏 I have some tiny remarks on the README though. |
| @@ -29,3 +29,8 @@ print $ulid; // 01b8kyr6g8bc61ce8r6k2t16hy | |||
| ## License | |||
|
|
|||
| MIT © [Robin van der Vleuten](https://www.robinvdvleuten.nl) | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Extraneous newline + could you move the section above the license so that stays at the bottom?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
Thank you for your work! I use ULIDs everyday now and it's way more convenient to deal with than UUIDs.
I've made a (very) small package allowing the use of ULIDs as primary keys in Doctrine. Would you mind adding a suggest so as to favor ULID adoption?
Thank you!
Ben