Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements delete directory method. #2

Closed
wants to merge 2 commits into from
Closed

Improvements delete directory method. #2

wants to merge 2 commits into from

Conversation

NerijusD
Copy link
Contributor

These changes affect DeleteDirectory when called recursively with force flag set.

Changes ensure that:

  • GetListing method is called only once - all data regarding files / directories are downloaded in single big chunk instead of making separate small requests. Thus improves bandwidth usage and response time.
  • Files and directories are deleted in right order, based on depth of directional hierarchy and type.

robinrodricks
robinrodricks reviewed Oct 30, 2016
View reviewed changes
Copy link
Owner

@robinrodricks robinrodricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested with single folders, empty folders and folders with multiple subfolders?

robinrodricks pushed a commit that referenced this pull request Nov 25, 2016
cleanup proxy implementation, merge #2
30d22cb
@robinrodricks
Copy link
Owner

I merged this manually in this commit.

Because I could not test with multiple servers (WasGetListingRecursive()) I added a boolean fastMode. I don't want to break the DeleteDirectory method.

robinrodricks pushed a commit that referenced this pull request May 4, 2017
@jblacker
Merge pull request #2 from hgupta9/master
e172249 
Pull upstream changes from master
robinrodricks pushed a commit that referenced this pull request Sep 22, 2017
@taoyouh
Merge pull request #2 from robinrodricks/master
343422c 
Pull updates
robinrodricks pushed a commit that referenced this pull request Oct 11, 2017
@taoyouh
Merge pull request #2 from robinrodricks/master
0c5fb13 
Pull from robinrodricks/FluentFTP
robinrodricks pushed a commit that referenced this pull request Feb 17, 2020
@n0ix
Merge pull request #2 from robinrodricks/master
b64aed5 
Upstream Merge
@FanDjango FanDjango mentioned this pull request Oct 25, 2021
Merged
@FanDjango FanDjango mentioned this pull request Nov 4, 2021
Merged
@FanDjango FanDjango mentioned this pull request Nov 18, 2021
Merged
@FanDjango FanDjango mentioned this pull request Sep 24, 2022
Closed
@FanDjango FanDjango mentioned this pull request Nov 16, 2022
Closed
@FanDjango FanDjango mentioned this pull request Feb 22, 2023
Closed
@FanDjango FanDjango mentioned this pull request Mar 12, 2023
Closed
@FanDjango FanDjango mentioned this pull request May 8, 2023
Closed
@anandgmenon anandgmenon mentioned this pull request Sep 19, 2023
Closed
@FanDjango FanDjango mentioned this pull request Nov 20, 2023
Closed
@FanDjango FanDjango mentioned this pull request Dec 29, 2023
Closed
@FanDjango FanDjango mentioned this pull request Mar 27, 2024
Closed
@FanDjango FanDjango mentioned this pull request Aug 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinrodricks robinrodricks robinrodricks left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NerijusD @robinrodricks