Fix issue where plugin isn't available via AMD or CommonJS module loaders. #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, thank you for your work on this plugin!
The problem: The plugin wasn't being exposed from the factory, so the AMD and CommonJS parts of the UMD weren't actually exporting anything usable for any application using either of those loaders.
The fix: Return the entire plugin to make it available to AMD and CommonJS module loaders. This is in line with the common UMD pattern, and does not break compatibility with the typical global variable definition.
See the "exposed public method" comment in this UMD explanation for a simplified version of what was added here.