Simple support for single page applications #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added .gitignore added possibility to keep the onscroll event handler stay even if the cache is full constructor returns an object with a method which resets the cache updated bower.json so it have the correct version set lastPixelDepth to 0 when reseting; renamed function so it is more descriptive one small detail I missed - fixed
Closed
|
Thanks! Merged into v08 dev branch b13de45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #24 I'm creating this pull request. It's a simple approach to have jquery-scrolldepth working on single page applications such as applications created in AngularJS or EmberJS.
I've added public
reset()method which resets state of the plugin. It can be executed in a SPA with some kind of a hook before transition to new view ends.@robflaherty is afraid of making the plugin overloaded with options and most likely will remove new
detachEventOnceCacheIsFulloption. It shouldn't be painful. Frankly, I'm not sure if the options is even needed. I did few test. Removed it and removed the condition in lambda function passed to$window.on('scroll.scrollDepth'.... My Ember app still works without errors. Maybe there is no need to taking care of attaching and detaching the event 😝