-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"reloading" scrolldepth #24
Comments
How about forking, create the fix, and the send a pull request? Thx |
@zepedrorocha - I'm not familiar with the best practices for reinitializing jQuery plugins on ajax page loads but I think something like a "reset" or "reload" method makes sense. (I've also had a few people ask about infinite scroll pages and for those I think the plugin might need a method to push new elements into the list of tracked elements.) If you'd like to send a pull request that would be great.. otherwise I'll have a look at it soon :) |
Will add this in the next iteration when I remove the jQuery dependency. |
Hi! I had similar issues. And I resolved them in my fork. We're creating single page application with Ember and we wanted to use your useful plugin 😸 The issue was with caching in your plugin and detaching
@robflaherty, should I create a pull request and you'll merge it? Or do you want to wait till you remove jQuery dependency and you'll go with your version? |
@nandy-andy Thanks, I think this is great. I'm wondering if there's a way to achieve the reset without requiring a new plugin option (I'm worried about the plugin becoming overloaded with options). What if the A pull request would be awesome. A lot of people have asked for this feature so I'd like to go ahead and include it in the next version. |
@nandy-andy Hey, if you want to submit a pull request for the work you already did, I can merge it into a dev branch and I'll work on modifying it so it doesn't require adding a new plugin option. If not, no worries :) |
Yeah, sorry. I wanted to play with it more but recently it's hard to find time. The pull request has been created: PR#53 |
@nandy-andy Thanks for the help. Hoping to release this and some other features sometime in the next few weeks. |
Hello. I'm using AngularJS page routing (Multiple Views). Since i don't refresh the entire webpage your code will unbind scroll event, eventually.
I wish I could "reload" the scrolldepth when the View is changed. I'm asking for some advise to find the best option. Thank you
The text was updated successfully, but these errors were encountered: