-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/model update v3 #49
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: FranziDiehr <[email protected]>
required fields Signed-off-by: FranziDiehr <[email protected]>
Added vocabulary "bibliographic-reference-type" to the list of concept schemes. Signed-off-by: FranziDiehr <[email protected]>
updated name of property and $ref to the vocabulary Signed-off-by: FranziDiehr <[email protected]>
Signed-off-by: FranziDiehr <[email protected]>
changed datatype property to not expect a vocabulary item Signed-off-by: FranziDiehr <[email protected]>
changed property pubilication to expect the identifier of bibliographic reference item Signed-off-by: FranziDiehr <[email protected]>
changed property publication to expect identifier of bibliographic reference item Signed-off-by: FranziDiehr <[email protected]>
added property a new property "standardsUsed" as discussed Signed-off-by: FranziDiehr <[email protected]>
fixed error Signed-off-by: FranziDiehr <[email protected]>
changed property accessURL and download URL to type array, because there can be multiple repositories for accessing th edistribution (e.g. GitHub, Zenodo)
added pattern for loincId
we decided against having a controlled vocabulary for data types
first draft, more concepts to be added
added descriptions for properties
added descriptions to properties
added description to properties
added descriptions to properties
added descriptions to properties
added descriptions to properties
added descriptions to properties
added descriptions to properties
added descriptions to properties and description to the entity
added descriptions to properties and description to entity
added description to property and entity
added descriptions to properties
typo Co-authored-by: LeipoldL <[email protected]> Signed-off-by: FranziDiehr <[email protected]>
cutoffthetop
previously approved these changes
Jul 10, 2024
…ehow forgot before)
… we need a general term for resources, that cannot be mapped to a specific theme
# PR Context We need to introduce consents given by persons in order to be able to publish their names and contact information in the metadata catalog. # Added Created consent entity and two new vocabularies. Added the vocabularies to concept-schemes.json --------- Signed-off-by: FranziDiehr <[email protected]> Co-authored-by: Nicolas Drebenstedt <[email protected]>
- drop anyOf from hasConsentStatus since we allow just one type - remove default from hasConsentStatus since we need it required - add identifierInPrimarySource to required fields
# PR Context <!-- Additional info for the reviewer --> # Added <!-- New features and interfaces --> - release script, creating merged-models. Merged models are written to a zip file, together with the content of the following directories: i18n, fields, vocabularies.
# Changes - new metadata fields included # Removed - outdated metadata fields removed --------- Signed-off-by: LeipoldL <[email protected]> Signed-off-by: FranziDiehr <[email protected]> Co-authored-by: Franziska Diehr <[email protected]> Co-authored-by: FranziDiehr <[email protected]>
# PR Context - cruft update --------- Signed-off-by: erichesse <[email protected]>
cutoffthetop
approved these changes
Oct 25, 2024
LeipoldL
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Context
We need to update our metadata model due to new insights deriving from a) consulting more standards and schemas specific to the modelling of health data, like upcoming profile "HealthDCAT-AP" in relation to the development of the EHDS (European Health Data Space).
Further, we introduce a new entity called "bibliographic reference". This new entity allows us to describe bibliographic references, e.g. publications (books, book sections, journal articles). With that, we added a new core entity to our metadata catalogue, which provides valuable information about RKI's research.
Added
resource
Changes
all entities
variable
activity
resource
distribution
vocabularies
date properties
YearMonthDay
,YearMonth
,Year
. Delete"format": "date"
and"format": "datetime"
to ensure validation.index.md
Deleted all information that were relevant to the "specification" of the model. We decided, that the maintenance of the specification is not worth its benefit (mainly interoperability with standards). In the future, it is more feasible and fitting to our use case to maintain mappings to the portals we will contribute to.
But we want to keep the index file, because we may add some more description on the schema on a more general level.
README.md
Removed