Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mx 1498 and mx 1480 configure mypy to follow imports and move pytest and mypy config into pyproject.toml #50

Conversation

rababerladuseladim
Copy link
Contributor

  • mypy pre-commit hook now always runs on all files instead of only changed files, which is the recommended way according to the mypy maintainer
  • mypy now shows errors in case of missing imports (prior: silently ignored missing imports)
  • move content of .mypy.ini and pytest.ini into pyproject.toml
  • update dependencies

@erichesse erichesse self-requested a review November 30, 2023 12:14
erichesse
erichesse previously approved these changes Nov 30, 2023
Copy link
Contributor

@erichesse erichesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you are so smart Henning!

@rababerladuseladim rababerladuseladim merged commit 9caf526 into main Nov 30, 2023
4 checks passed
@rababerladuseladim rababerladuseladim deleted the feature/mx-1498-configure-mypy-to-follow-imports-in-mex-common branch November 30, 2023 13:52
carolinscholl pushed a commit that referenced this pull request Dec 6, 2023
… pytest and mypy config into pyproject.toml (#50)

- mypy pre-commit hook now always runs on all files instead of only
changed files, which is the [recommended way according to the mypy
maintainer](python/mypy#13916)
- mypy now shows errors in case of missing imports (prior: silently
ignored missing imports)
- move content of `.mypy.ini` and `pytest.ini` into pyproject.toml
- update dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants