fixed isset problem with parent objects, used magic method __isset() #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 31, 2013 08:58
|
Needs a better comment, just something like "this is called when isset() is called". Space after the comments like others. You need to support arrays too. And needs tests. Otherwise I'll PR it later and make the changes myself, just not much time with this lately. |
|
ok thanks |
|
This has been merged into the develop branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the service provider to automagically create Presenter instances of objects, I found there was a problem with using Form::model(), as it uses isset() to check values on the bound model. Since Presenter is just a wrapper, the values are not set. By implementing the __isset() it keeps the Form::model() working as expected. Hopefully this is an acceptable addition.