-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change log level of some logs to debug #274
Change log level of some logs to debug #274
Conversation
Some of these should not just serve as application debug, but as useful info when e.g. setting up the connection and getting a failed connection without details otherwise. It is hard to tell from the diff if this is now affected, but it looks like it. |
Maybe we should change this into a setting via config flow? |
Wouldn't that be almost the same as the Home Assistant "Enable debug logging" option? Main difference would be that you can enable/disable it per config entry. "Enable debug logging" is for the whole integration so all config entries. Not sure how important that is. |
Good to have that confirmed, that's where such errors are most helpful.
Do you mean shown as error while going through the config flow? Or does it show an error every night while the inverter is unreachable? |
However, looking back I am not sure why I mentioned it since it only gets in that state when the integration gets (re)loaded. |
That is because your inverter is currently off and therefore not available to collect data? |
Since this is no longer needed, i'll close this PR. |
I had to analyze my HA logs for another issue and it was difficult due to the Omnik integration generating a lot of logging during the night.
I would suggest to change these logs level to debug to avoid polluting the logs when not needed. When needed for debugging one can easily enable debug logging for the integration to get them again.
I had this running for a couple of days and seems to work as intended.