Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make config data changeable in the options dialog #188

Merged
merged 32 commits into from
Apr 12, 2023
Merged

Make config data changeable in the options dialog #188

merged 32 commits into from
Apr 12, 2023

Conversation

raymanP
Copy link
Contributor

@raymanP raymanP commented Apr 10, 2023 •
edited
Loading

Allows to change name, host, username, password and serial

Fixes #178, #184

raymanP and others added 29 commits April 9, 2023 15:58
@raymanP
added host, username and password to config options: robbinjanssen#178,
b18e0b8 
robbinjanssen#184
@raymanP
Added host, username, password option strings
77086c9
@raymanP
added options config by source type
fd28afa
@raymanP
fixed typo
8a08a0f
@raymanP
fixed conf type
556d1f1
@raymanP
options added validate host
496caa2
@raymanP
try fix config
4804a35
@raymanP
more options changes
b0cf0d9
@raymanP
added tcp options
6b22e66
@raymanP
updated options DE
62824c6
@raymanP
Updated options EN
c2a5a4c
@raymanP
Updated options NL
301810e
@raymanP
fixed config update
3d5bb61
@raymanP
fixed integration don't update title
6b0b4a5
@raymanP
added errors to options
31d1f48
@raymanP
removed unneeded entry in options
3d277d0
@raymanP
added name config in options
c5ccb43
@raymanP
fixed options
e1103fd
@raymanP
fixed config options typo
a5c4a9a
@raymanP
updated DE
810f021
@raymanP
Updated EN
dee01d4
@raymanP
Updated NL
5a50458
@raymanP
Updated strings (added name)
071bb80
@raymanP
change name only if specified
73415c9
@raymanP
Updated DE
b1925b0
@raymanP
Updated EN
e9cc982
@raymanP
Updated NL
cf0bd1e
@raymanP
fixed empty name in options
389b700
@raymanP
Fixed setting empty name
a8141a9
@raymanP raymanP changed the title Make config data changeble in the options dialog #178, #184 Make config data changeble in the options dialog Apr 10, 2023
klaasnicolaas
klaasnicolaas previously requested changes Apr 10, 2023
View reviewed changes
custom_components/omnik_inverter/translations/nl.json Outdated Show resolved Hide resolved
custom_components/omnik_inverter/config_flow.py Outdated Show resolved Hide resolved
@raymanP raymanP requested a review from klaasnicolaas April 10, 2023 16:11
@MarijnS95
Copy link
Collaborator

Title suggestion: s/changeble/changeable.

@klaasnicolaas klaasnicolaas added the new-feature New features or options. label Apr 10, 2023
@robbinjanssen robbinjanssen changed the title Make config data changeble in the options dialog Make config data changeable in the options dialog Apr 11, 2023
@robbinjanssen
Copy link
Owner

robbinjanssen commented Apr 11, 2023 •
edited
Loading

@raymanP can you fix the black issue? Probably as simple as running poetry run pre-commit run --all-files black on your system :)

@raymanP
Copy link
Contributor Author

raymanP commented Apr 11, 2023

Code format fixed ;)

@robbinjanssen robbinjanssen merged commit f38e943 into robbinjanssen:main Apr 12, 2023
@robbinjanssen
Copy link
Owner

Release has been tagged! Thanks for your contribution

@github-actions github-actions bot locked and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robbinjanssen robbinjanssen robbinjanssen approved these changes

@klaasnicolaas klaasnicolaas Awaiting requested review from klaasnicolaas

Assignees
No one assigned
Labels
new-feature New features or options.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change IP address
4 participants
@raymanP @MarijnS95 @robbinjanssen @klaasnicolaas