Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing branches tracking and sync translations only from last release #267

Closed
rob006 opened this issue Mar 6, 2020 · 0 comments · Fixed by #270
Closed

Consider removing branches tracking and sync translations only from last release #267

rob006 opened this issue Mar 6, 2020 · 0 comments · Fixed by #270
Assignees
@rob006
Labels
enhancement New feature or request

Comments

@rob006
Copy link
Member

rob006 commented Mar 6, 2020

Since beta 12 there is English fallback for missing translations - translating unreleased version does no have much sense now. It is also a little confusing, since new phrases are fetched, but changed phrases are ignored, so you can't complete translation before release anyway.

Fallback does not work for official extensions (see flarum/framework#2020 (comment)), so we probably should track branches for them (at least for now).
@rob006 rob006 added the enhancement New feature or request label Mar 6, 2020
@rob006 rob006 self-assigned this Mar 6, 2020
rob006 added a commit to rob006-software/flarum-translations-builder that referenced this issue Mar 7, 2020
@rob006
Do not automatically add source for unstable branch on extension conf…
d002b49 
…ig generation.

refs rob006-software/flarum-translations#267
rob006 added a commit to rob006-software/flarum-translations-builder that referenced this issue Mar 7, 2020
@rob006
Do not automatically add source for unstable branch on extension conf…
7be1ff6 
…ig generation. (fixup)

refs rob006-software/flarum-translations#267
rob006 added a commit to rob006/flarum-translations that referenced this issue Mar 7, 2020
@rob006
Remove sources for branches from config.
3de4fe2 
fix rob006-software#267
@rob006 rob006 mentioned this issue Mar 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rob006 rob006

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove sources for branches from config rob006/flarum-translations
1 participant
@rob006