Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specifications: #72

Merged
merged 6 commits into from
Sep 28, 2021
Merged

specifications: #72

merged 6 commits into from
Sep 28, 2021

Conversation

drr00t
Copy link
Member

@drr00t drr00t commented Sep 11, 2021

  • initial thinking about specifications

- initial thinking about specifications
@drr00t drr00t marked this pull request as draft September 11, 2021 14:48
@codecov
Copy link

codecov bot commented Sep 11, 2021

Codecov Report

Merging #72 (a8c343e) into master (a8fd236) will decrease coverage by 2.54%.
The diff coverage is 38.46%.

❗ Current head a8c343e differs from pull request most recent head 65dd688. Consider uploading reports for the commit 65dd688 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
- Coverage   70.62%   68.08%   -2.55%     
==========================================
  Files          35       41       +6     
  Lines         303      329      +26     
==========================================
+ Hits          214      224      +10     
- Misses         89      105      +16     
Impacted Files Coverage Δ
...low.Business.Cqrs/CommandHandlers/CommandResult.cs 75.00% <ø> (ø)
...main/Specifications/LinqExpressionSpecification.cs 0.00% <0.00%> (ø)
...rc/DFlow.Domain/Specifications/NotSpecification.cs 0.00% <0.00%> (ø)
src/DFlow.Domain/Specifications/OrSpecification.cs 0.00% <0.00%> (ø)
...ow.Domain/Specifications/CompositeSpecification.cs 33.33% <33.33%> (ø)
...rc/DFlow.Domain/Specifications/AndSpecification.cs 50.00% <50.00%> (ø)
...Flow.Domain/Specifications/LogicalSpecification.cs 71.42% <71.42%> (ø)
src/DFlow.Domain/Validation/BaseValidation.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8fd236...65dd688. Read the comment docs.

- integrating Specification into Dflow for validation
 - expression support
 - version update
 - fix codacy problems
@drr00t drr00t marked this pull request as ready for review September 28, 2021 23:51
@drr00t drr00t merged commit 2fbb546 into master Sep 28, 2021
@drr00t drr00t deleted the feature/dflow-specifications-framework branch September 28, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant