fix: Fixed early access of AbstractEmbedFinder::$feed

roadiz · Nov 26, 2024 · ee3b935 · ee3b935
1 parent 19561ee
commit ee3b935
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/src/MediaFinders/AbstractEmbedFinder.php b/src/MediaFinders/AbstractEmbedFinder.php
@@ -26,7 +26,7 @@
  */
 abstract class AbstractEmbedFinder implements EmbedFinderInterface
 {
-    protected array|\SimpleXMLElement|null $feed;
+    protected array|\SimpleXMLElement|null $feed = null;
     protected string $embedId;
     protected ?string $key = null;
 
@@ -93,11 +93,8 @@ public function exists(): bool
     public function getFeed(): array|\SimpleXMLElement|null
     {
         if (null === $this->feed) {
-            $rawFeed = $this->getMediaFeed();
-            if ($rawFeed instanceof StreamInterface) {
-                $rawFeed = $rawFeed->getContents();
-            }
-            if (null !== $rawFeed) {
+            $rawFeed = $this->getMediaFeed()->getContents();
+            if (null !== $rawFeed && \json_validate($rawFeed)) {
                 $feed = json_decode($rawFeed, true);
                 if (is_array($feed)) {
                     $this->feed = $feed;