feat!: Changed WebResponseDataTransformerInterface transform signatur…

…e to allow passing an existing WebResponseInterface
roadiz · Nov 25, 2024 · bcffe3e · bcffe3e
1 parent 38c84fb
commit bcffe3e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/Api/DataTransformer/WebResponseDataTransformerInterface.php b/src/Api/DataTransformer/WebResponseDataTransformerInterface.php
@@ -13,10 +13,16 @@ interface WebResponseDataTransformerInterface
      * @template T of PersistableInterface
      *
      * @param T $object
+     * @param WebResponseInterface|null $output Pass an existing WebResponseInterface instance to avoid creating a new one.
      *
      * @return WebResponseInterface<T>|null
      */
-    public function transform(PersistableInterface $object, string $to, array $context = []): ?WebResponseInterface;
+    public function transform(
+        PersistableInterface $object,
+        string $to,
+        array $context = [],
+        ?WebResponseInterface $output = null,
+    ): ?WebResponseInterface;
 
     public function createWebResponse(): WebResponseInterface;
 }
diff --git a/src/Api/DataTransformer/WebResponseOutputDataTransformer.php b/src/Api/DataTransformer/WebResponseOutputDataTransformer.php
@@ -79,9 +79,9 @@ public function createWebResponse(): WebResponseInterface
         return new ($this->webResponseClass)();
     }
 
-    public function transform(PersistableInterface $object, string $to, array $context = []): ?WebResponseInterface
+    public function transform(PersistableInterface $object, string $to, array $context = [], ?WebResponseInterface $output = null): ?WebResponseInterface
     {
-        $output = $this->createWebResponse();
+        $output = $output ?? $this->createWebResponse();
         $output->setItem($object);
         if ($object instanceof NodesSources) {
             if ($output instanceof RealmsAwareWebResponseInterface) {