fix(Rozier): Call off() on undefined element

roadiz · Sep 18, 2023 · dd4324d · dd4324d
1 parent 9a170d5
commit dd4324d
Show file tree

Hide file tree

Showing 12 changed files with 24 additions and 16 deletions.
diff --git a/lib/Rozier/src/Resources/app/Rozier.js b/lib/Rozier/src/Resources/app/Rozier.js
@@ -232,16 +232,22 @@ export default class Rozier {
     bindMainTrees() {
         // TREES
         let $nodeTree = $('.nodetree-widget .root-tree')
-        $nodeTree.off('change.uk.nestable')
-        $nodeTree.on('change.uk.nestable', this.onNestableNodeTreeChange)
+        if ($nodeTree.length) {
+            $nodeTree.off('change.uk.nestable')
+            $nodeTree.on('change.uk.nestable', this.onNestableNodeTreeChange)
+        }
 
         let $tagTree = $('.tagtree-widget .root-tree')
-        $tagTree.off('change.uk.nestable')
-        $tagTree.on('change.uk.nestable', this.onNestableTagTreeChange)
+        if ($tagTree.length) {
+            $tagTree.off('change.uk.nestable')
+            $tagTree.on('change.uk.nestable', this.onNestableTagTreeChange)
+        }
 
         let $folderTree = $('.foldertree-widget .root-tree')
-        $folderTree.off('change.uk.nestable')
-        $folderTree.on('change.uk.nestable', this.onNestableFolderTreeChange)
+        if ($folderTree.length) {
+            $folderTree.off('change.uk.nestable')
+            $folderTree.on('change.uk.nestable', this.onNestableFolderTreeChange)
+        }
 
         // Tree element name
         this.$mainTreeElementName = this.$mainTrees.find('.tree-element-name')

diff --git a/lib/Rozier/src/Resources/app/components/tabs/MainTreeTabs.js b/lib/Rozier/src/Resources/app/components/tabs/MainTreeTabs.js
@@ -17,7 +17,9 @@ export default class MainTreeTabs {
     }
 
     unbind() {
-        this.tabsMenu.off('change.uk.tab', this.onTabChange)
+        if (this.tabsMenu) {
+            this.tabsMenu.off('change.uk.tab', this.onTabChange)
+        }
     }
 
     onTabChange(event, activeItem, previousItem) {

diff --git a/lib/Rozier/src/Resources/views/partials/css-inject.html.twig b/lib/Rozier/src/Resources/views/partials/css-inject.html.twig
@@ -1,7 +1,7 @@
 
 <link href="{{ asset('css/vendor.00b2be12b114cc414b2c.css', 'Rozier') }}" rel="stylesheet">
 
-<link href="{{ asset('css/app.44c39cecf098349e8d63.css', 'Rozier') }}" rel="stylesheet">
+<link href="{{ asset('css/app.0233cdc4d2bebcd7bc96.css', 'Rozier') }}" rel="stylesheet">
 
 
 

diff --git a/lib/Rozier/src/Resources/views/partials/js-inject.html.twig b/lib/Rozier/src/Resources/views/partials/js-inject.html.twig
@@ -1,5 +1,5 @@
 
-<script src="{{ asset('js/vendor.118e12fff2243a310d56.js', 'Rozier') }}" defer type="text/javascript"></script>
+<script src="{{ asset('js/vendor.9a0ad0e6c30086c8785f.js', 'Rozier') }}" defer type="text/javascript"></script>
 
-<script src="{{ asset('js/app.118e12fff2243a310d56.js', 'Rozier') }}" defer type="text/javascript"></script>
+<script src="{{ asset('js/app.9a0ad0e6c30086c8785f.js', 'Rozier') }}" defer type="text/javascript"></script>
 
diff --git a/lib/Rozier/src/Resources/views/partials/simple-js-inject.html.twig b/lib/Rozier/src/Resources/views/partials/simple-js-inject.html.twig
@@ -1,3 +1,3 @@
 
-<script src="{{ asset('js/simple.118e12fff2243a310d56.js', 'Rozier') }}" defer type="text/javascript"></script>
+<script src="{{ asset('js/simple.9a0ad0e6c30086c8785f.js', 'Rozier') }}" defer type="text/javascript"></script>
 
diff --git a/...c/static/css/app.44c39cecf098349e8d63.css → ...c/static/css/app.0233cdc4d2bebcd7bc96.css b/...c/static/css/app.44c39cecf098349e8d63.css → ...c/static/css/app.0233cdc4d2bebcd7bc96.css
diff --git a/lib/Rozier/src/static/css/app.0233cdc4d2bebcd7bc96.css.map b/lib/Rozier/src/static/css/app.0233cdc4d2bebcd7bc96.css.map
diff --git a/lib/Rozier/src/static/css/app.44c39cecf098349e8d63.css.map b/lib/Rozier/src/static/css/app.44c39cecf098349e8d63.css.map
diff --git a/lib/Rozier/src/static/css/vendor.00b2be12b114cc414b2c.css.map b/lib/Rozier/src/static/css/vendor.00b2be12b114cc414b2c.css.map
diff --git a/...src/static/js/app.118e12fff2243a310d56.js → ...src/static/js/app.9a0ad0e6c30086c8785f.js b/...src/static/js/app.118e12fff2243a310d56.js → ...src/static/js/app.9a0ad0e6c30086c8785f.js
diff --git a/.../static/js/simple.118e12fff2243a310d56.js → .../static/js/simple.9a0ad0e6c30086c8785f.js b/.../static/js/simple.118e12fff2243a310d56.js → .../static/js/simple.9a0ad0e6c30086c8785f.js
diff --git a/.../static/js/vendor.118e12fff2243a310d56.js → .../static/js/vendor.9a0ad0e6c30086c8785f.js b/.../static/js/vendor.118e12fff2243a310d56.js → .../static/js/vendor.9a0ad0e6c30086c8785f.js
Original file line number	Diff line number	Diff line change
		@@ -1,3 +1,3 @@

		<script src="{{ asset('js/simple.118e12fff2243a310d56.js', 'Rozier') }}" defer type="text/javascript"></script>
		<script src="{{ asset('js/simple.9a0ad0e6c30086c8785f.js', 'Rozier') }}" defer type="text/javascript"></script>