fix(Node): Always set node TTL against its node-type

roadiz · May 22, 2024 · a772d06 · a772d06
1 parent 353d4f4
commit a772d06
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/lib/RoadizCoreBundle/src/Node/NodeFactory.php b/lib/RoadizCoreBundle/src/Node/NodeFactory.php
@@ -47,9 +47,10 @@ public function create(
             $node->setNodeType($type);
         }
 
-        if ($type instanceof NodeType) {
-            $node->setTtl($type->getDefaultTtl());
+        if ($node->getNodeType() instanceof NodeType) {
+            $node->setTtl($node->getNodeType()->getDefaultTtl());
         }
+
         if (null !== $parent) {
             $node->setParent($parent);
         }

diff --git a/lib/Rozier/src/Controllers/Nodes/NodesController.php b/lib/Rozier/src/Controllers/Nodes/NodesController.php
@@ -328,6 +328,7 @@ public function addAction(Request $request, int $nodeTypeId, ?int $translationId
 
         $node = new Node();
         $node->setNodeType($type);
+        $node->setTtl($type->getDefaultTtl());
 
         $chroot = $this->nodeChrootResolver->getChroot($this->getUser());
         if (null !== $chroot) {

diff --git a/lib/Rozier/src/Traits/NodesTrait.php b/lib/Rozier/src/Traits/NodesTrait.php
@@ -26,11 +26,9 @@ abstract protected function getNodeFactory(): NodeFactory;
      * @param NodeTypeInterface|null $type
      *
      * @return Node
-     * @throws \Doctrine\ORM\ORMException
-     * @throws \Doctrine\ORM\OptimisticLockException
      */
     protected function createNode(
-        $title,
+        string $title,
         TranslationInterface $translation,
         Node $node = null,
         NodeTypeInterface $type = null